Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation for c# not considering variable name is case sensitive [STUD-69312] #316

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

aoltean16
Copy link
Collaborator

@aoltean16 aoltean16 commented Apr 12, 2024

The default behavior was the VB one, checking for variable names was done with StringComparison.OrdinalIgnoreCase
https://uipath.atlassian.net/browse/STUD-69312

@aoltean16 aoltean16 self-assigned this Apr 12, 2024
@aoltean16 aoltean16 force-pushed the fix/csharp_variablename_casesensitive branch from 0a54ac0 to e81aa4f Compare April 12, 2024 13:20
@aoltean16 aoltean16 force-pushed the fix/csharp_variablename_casesensitive branch from e81aa4f to fdf7a60 Compare April 12, 2024 13:24
@aoltean16 aoltean16 merged commit 7d795e5 into develop Apr 12, 2024
2 checks passed
@aoltean16 aoltean16 deleted the fix/csharp_variablename_casesensitive branch April 12, 2024 14:45
@aoltean16 aoltean16 changed the title Fix validation for c# not considering variable name is case sensitive Fix validation for c# not considering variable name is case sensitive [STUD-69312] Apr 15, 2024
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
@@ -29,7 +29,7 @@ public abstract class JustInTimeCompiler
public record CompilerInput(string Code, IReadOnlyCollection<string> ImportedNamespaces) { }

public record ExpressionToCompile(string Code, IReadOnlyCollection<string> ImportedNamespaces,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants